Update qhimm.xml #209
Update qhimm.xml #209
Conversation
|
Ok thank you. I will work on that as wellSincerely Brad HowlettOn Nov 22, 2024, at 11:20 AM, Julian Xhokaxhiu ***@***.***> wrote:
@julianxhokaxhiu requested changes on this pull request.
Almost there :) In your mod.xml you miss the tag <ID> which must the same used here in the catalog ( as it has to match ). This is required to make sure all mods are unique in the catalog and they don't clash by the name. Thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I added the ID to the mod.xml. I then reuploaded everything. I did change the gdrive ID in my PR to target the new file with the fixed mod.xml. |
|
Thanks, I'm checking the PR but the download of the drive file seems to be the same as before ( and if I try to access it says it doesn't exist ). Did you commit the change to the same branch where you've opened the PR from? |
|
Darn. Sorry. I’m trying to learn. No I didn’t but I willSincerely Brad HowlettOn Nov 23, 2024, at 11:12 AM, Julian Xhokaxhiu ***@***.***> wrote:
Thanks, I'm checking the PR but the download of the drive file seems to be the same as before ( and if I try to access it says it doesn't exist ). Did you commit the change to the same branch where you've opened the PR from?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
fixed GDrive link
|
I figured out now how to edit and commit. Thank you for you patience and help. Should the GDrive be pointing at my WereXIII folder or just the iro. If it is just the iro then I will fix again
On Saturday, November 23, 2024 at 11:12:20 AM CST, Julian Xhokaxhiu ***@***.***> wrote:
Thanks, I'm checking the PR but the download of the drive file seems to be the same as before ( and if I try to access it says it doesn't exist ). Did you commit the change to the same branch where you've opened the PR from?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This commit is if you are needing the GDrive ID to be the IRO. The previous commit from 20 minutes ago is if the GDrive ID needs to be the entire folder.
|
I created 2 commits today. The first is if the GDrive ID needs to point to my entire mod folder and the second is if it just needs to point to the iro |
updated file size to kb
|
Well done :) Merged and tested, all works as intended, thank you and congratulations! |
I believe I have everything right. I hope